Missing UpdateHmdCaps() in OculusRiftHMD

There is a missing UpdateHmdCaps() in bool FOculusRiftHMD::EnablePositionalTracking(bool enable); that makes the call irrelevant.

bool FOculusRiftHMD::EnablePositionalTracking(bool enable)
{
#ifdef OVR_VISION_ENABLED
	bHmdPosTracking = enable;
	UpdateHmdCaps(); //This is needed so the HMD correctly updates it's status
	return IsPositionalTrackingEnabled();
#else
	OVR_UNUSED(enable);
	return false;
#endif
}

I’m using Unreal 4.5 so that may have been fixed since…

Hi ,

Sorry for the delay in responding to your post. I checked the source code for 4.6.1 and our latest internal build, and I do not see the line you mentioned included in either one. Before I enter a ticket to have this looked into, I wanted to check and see if you would like to submit your fix as a pull request on GitHub.

Hi ,

No, I’m actually getting the source from the P4 trunk of Epic, so you can go ahead and create a ticket for that. This is not a big issue but the line I added is definetly needed for the position tracking to be enabled correctly using this call.

Just wanted to give a heads up! Would there be any reason for me to do a pull request on GitHub for that other than notifying you the “correct” way?

Mick

I entered a ticket for this issue (UE-10983).

Whenever I see a user who finds an issue in source code and provides a suggested fix for it, I typically will ask if they would be interested in submitting a pull request containing their fix. Each pull request is assigned to an engineer for review and, if we decide to bring in the pull request, the user who submitted it is added to the list of Community Developers in the Engine credits. I just want to make sure users have the opportunity to receive credit for their contributions, which we can’t do if we submit a ticket and fix the issue internally.