Minor issues in source

if (Function->FunctionFlags & FUNC_Native)
{
Function->Invoke(this, NewStack, ReturnValueAdress);
}
else
{
Function->Invoke(this, NewStack, ReturnValueAdress);
}
ScriptCore.cpp#L1301

If/Else are the same.

.com/EpicGames/UnrealEngine/commit/ea171c613e8f501f632f30d330f6a1c3e6029d85#diff-b0c09054e952c95f663cea8b426b2fba


if ((Struct->StructFlags & STRUCT_SerializeFromMismatchedTag) && (Tag.Type != NAME_StructProperty || (Tag.StructName != Struct->GetFName())) && Struct->StructFlags & STRUCT_SerializeFromMismatchedTag)

PropertyStruct.cpp#L300

Two times: Struct->StructFlags & STRUCT_SerializeFromMismatchedTag

.com/EpicGames/UnrealEngine/commit/eb44cd9882307914c9176bc9529d2da7d0e2d8f1


	UPackage* FilenamePkg = (ExistingPackage ? ExistingPackage : CreatePackage(nullptr, *PackageNameToCreate));
	if (FilenamePkg != ExistingPackage && (LoadFlags & LOAD_PackageForPIE))
	{
		FilenamePkg->SetPackageFlags(PKG_PlayInEditor);
	}

Linker.cpp#L610

FilenamePkg was used and later tested against nullptr. CreatePackage could return nullptr if “none” name provided.

.com/EpicGames/UnrealEngine/commit/0c5bc8be6d638089e91c4a14c6ee2a06a1554000#diff-8cb93ce68403c06908ea087772a869c4R1146


Is it ok to add more issues here? It’s such a pain to make a question each time…also github was a unicorn to me all day. ;_;

I could probably fix them and make a PR, but, in most cases i just don’t know what to put there like in case #1.

Hello S-ed,

Thank you for reporting these issues. I’ve placed an individual bug report for each. You can find them here: UE-38233 UE-38235 UE-38237

You can feel free to report these on the Answerhub any time when you don’t know what the fix would be. Otherwise, a pull request would be best.

Have a nice day!

Wow, Epic devs answered on my comments on each issue. Thought on GH it’ll take eternity to be mentioned.

Then I’ll stick with PR. I think Devs would navigate through faster with it even w/o accepting one, right?

That’s correct, it’ll also allow them to speak to you directly if there are any questions or corrections they need to make.

In the future, please only report an issue in one area. Reporting this here and through comments on github resulted in some confusion and multiple fixes for the same issues in multiple branches. I’m getting it sorted out, but please avoid multiple reports in the future.